Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node:timers) calling refresh breaks the timers #3361

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix(node:timers) calling refresh breaks the timers #3361

merged 1 commit into from
Jan 20, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 20, 2025

Calling TImeout#refresh does not update #timer making it impossible to cancel
/refresh the timer.

@vicb vicb requested review from a team as code owners January 20, 2025 08:28
@vicb
Copy link
Contributor Author

vicb commented Jan 20, 2025

Thanks for the review!

@vicb vicb merged commit d171c7f into main Jan 20, 2025
15 checks passed
@vicb vicb deleted the fix/refresh branch January 20, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@garrettgu10 garrettgu10 Awaiting requested review from garrettgu10 garrettgu10 is a code owner automatically assigned from cloudflare/workers-runtime-1

@Frederik-Baetens Frederik-Baetens Awaiting requested review from Frederik-Baetens Frederik-Baetens is a code owner automatically assigned from cloudflare/workers-runtime-1

@IgorMinar IgorMinar Awaiting requested review from IgorMinar IgorMinar is a code owner automatically assigned from cloudflare/workers-frameworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicb @jasnell